refactor(monitoring): simplify notification system and remove auto-cleanup

- Replace state-based notifications with direct alert functions
- Remove auto-cleanup functionality from disk monitoring and configuration
- Simplify lock acquisition/release across all monitoring scripts
- Add execute_hana_sql helper functions for consistent SQL execution
- Remove state file tracking in favor of direct file operations
- Standardize error handling with exit codes on critical failures
- Clean up hana.conf by removing unused auto-delete directory settings

hana_backup.sh

@@ -12,31 +12,30 @@ source "${SCRIPT_DIR}/hana.conf"
 source "${SCRIPT_DIR}/hana_lib.sh"
 
 # Acquire lock
-LOCK_FILE=$(acquire_lock "$SCRIPT_NAME")
-if [ $? -ne 0 ]; then
+if ! acquire_lock "$SCRIPT_NAME"; then
     exit 1
 fi
-trap 'release_lock "$LOCK_FILE"' EXIT
+trap 'release_lock "$SCRIPT_NAME"' EXIT
 
 log_message "$SCRIPT_NAME" "Starting backup status check..."
 
 # Check if hdbsql is available
 if [ ! -x "$HDBSQL_PATH" ]; then
     log_message "$SCRIPT_NAME" "ERROR: hdbsql not found or not executable at ${HDBSQL_PATH}"
-    send_notification_if_changed "$SCRIPT_NAME" "hana_hdbsql_path_backup" "HANA Monitor Error" "hdbsql not found or not executable at ${HDBSQL_PATH}" "true" "HDBSQL_ERROR"
+    send_alert "$SCRIPT_NAME" "HANA Monitor Error" "hdbsql not found or not executable at ${HDBSQL_PATH}"
     exit 1
 fi
 
 # SQL Query for last successful backup
 BACKUP_SQL="SELECT TOP 1 SYS_START_TIME FROM M_BACKUP_CATALOG WHERE ENTRY_TYPE_NAME = 'complete data backup' AND STATE_NAME = 'successful' ORDER BY SYS_START_TIME DESC"
 
-# Execute SQL query as HANA user with improved error handling
-backup_result=$(su - "$HANA_USER" -c "$HDBSQL_PATH -U $HANA_USER_KEY -j -a -x \"$BACKUP_SQL\"" 2>&1)
+# Execute SQL query
+backup_result=$(execute_hana_sql "$BACKUP_SQL")
 sql_status=$?
 
 if [ $sql_status -ne 0 ]; then
     log_message "$SCRIPT_NAME" "ERROR: Failed to execute backup query. Exit code: ${sql_status}"
-    send_notification_if_changed "$SCRIPT_NAME" "hana_backup_query_error" "HANA Backup Error" "Failed to execute backup query. Exit code: ${sql_status}" "true" "QUERY_ERROR"
+    send_alert "$SCRIPT_NAME" "HANA Backup Error" "Failed to execute backup query. Exit code: ${sql_status}"
     exit 1
 fi
 
@@ -45,18 +44,15 @@ last_backup_date=$(echo "$backup_result" | tr -d '"' | sed 's/\..*//')
 if [[ -z "$last_backup_date" || "$last_backup_date" == *"error"* || "$last_backup_date" == *"Error"* ]]; then
     message="No successful complete data backup found for ${COMPANY_NAME} HANA."
     log_message "$SCRIPT_NAME" "CRITICAL: ${message}"
-    send_notification_if_changed "$SCRIPT_NAME" "hana_backup_status" "HANA Backup" "$message" "true" "NO_BACKUP"
+    send_alert "$SCRIPT_NAME" "HANA Backup" "$message"
     exit 1
 fi
 
-# Clear any previous query error state
-send_notification_if_changed "$SCRIPT_NAME" "hana_backup_query_error" "HANA Backup" "Backup query successful." "false" "OK"
-
 # Calculate backup age
 last_backup_epoch=$(date -d "$last_backup_date" +%s 2>/dev/null)
 if [ $? -ne 0 ]; then
     log_message "$SCRIPT_NAME" "ERROR: Failed to parse backup date: ${last_backup_date}"
-    send_notification_if_changed "$SCRIPT_NAME" "hana_backup_status" "HANA Backup" "Failed to parse backup date: ${last_backup_date}" "true" "DATE_PARSE_ERROR"
+    send_alert "$SCRIPT_NAME" "HANA Backup" "Failed to parse backup date: ${last_backup_date}"
     exit 1
 fi
 
@@ -73,11 +69,11 @@ fi
 if [ $age_seconds -gt $threshold_seconds ]; then
     message="Last successful HANA backup for ${COMPANY_NAME} is ${age_hours} hours old, which exceeds the threshold of ${BACKUP_THRESHOLD_HOURS} hours. Last backup was on: ${last_backup_date}."
     log_message "$SCRIPT_NAME" "CRITICAL: ${message}"
-    send_notification_if_changed "$SCRIPT_NAME" "hana_backup_status" "HANA Backup" "$message" "true" "${age_hours}h"
+    send_alert "$SCRIPT_NAME" "HANA Backup" "$message"
+    exit 1
 else
     message="Last successful backup is ${age_hours} hours old (Threshold: ${BACKUP_THRESHOLD_HOURS} hours)."
     log_message "$SCRIPT_NAME" "SUCCESS: ${message}"
-    send_notification_if_changed "$SCRIPT_NAME" "hana_backup_status" "HANA Backup" "$message" "false" "OK"
 fi
 
 log_message "$SCRIPT_NAME" "Backup check complete."